kata: build incrementally using crane#2383
Conversation
|
Let's fix this in #2387. |
|
Oh no, that was not what I meant to close! |
e7cd04e to
332a571
Compare
|
Nice, this seems to fully wok now. |
|
Added a second commit, making things a little more incremental. On my machine, reduces One caveat of this is that changing e.g. a Yeah tbh I am not super happy with this step. It's a bit faster, but also less clean. I still have one more idea I'll add in a third commit, and then we'll have three choices to pick from. |
|
With crane replaced by crate2nix instead:
Which means that this solution is not only much uglier and harder to maintain, it's also not straightforward to compare performance 🙂 The upside of this solution is that changing e.g. agent code, then rebuilding genpolicy immediately uses the cached output, which is nice. I have a personal preference but am curious to see what you think. Each commit is a slightly different approach that warrants separate testing and consideration. |
0bc4b93 to
12f4847
Compare
kata.sourcepackage and consumed from thereCargo.lock/Cargo.tomlfiles require full rebuild (doesn't matter of upstream or through our patches)agentstill takes ~1:30min, because the entire agent still needs to be rebuilt and tested, but that's still significantly faster than before